Reuse TextLayoutInfo in queue_text #14997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UkoeHB
commented
Aug 31, 2024
| @@ -183,7 +183,9 @@ pub fn update_text2d_layout( | |||
| .map(|height| scale_value(height, scale_factor)), | |||
| }; | |||
|
|
|||
| let text_layout_info = text_layout_info.into_inner(); | |||
There was a problem hiding this comment.
This will trigger change detection even if queue_text returns an error. Doesn't seem important.
alice-i-cecile
added
C-Performance
MiniaczQ
approved these changes
Sep 2, 2024
alice-i-cecile
approved these changes
Sep 2, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Don't reallocate
TextLayoutInfoevery time it needs to be updated.Solution
Reuse existing allocation.