Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reallocate scale factors in measure_text_system #14999

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Don't reallocate scale factors in measure_text_system #14999

merged 3 commits into from
Sep 2, 2024

Conversation

UkoeHB
Copy link
Contributor

@UkoeHB UkoeHB commented Aug 31, 2024

Objective

  • Reuse allocation of scale_factors in measure_text_system.

Solution

  • Move it to a Local.

@alice-i-cecile alice-i-cecile added C-Performance A change motivated by improving speed, memory usage or compile times A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 31, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 2, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 2, 2024
Merged via the queue into bevyengine:main with commit 3227c3d Sep 2, 2024
27 checks passed
@UkoeHB UkoeHB deleted the measure_system branch September 2, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MiniaczQ MiniaczQ MiniaczQ approved these changes

Assignees
No one assigned
Labels
A-Text Rendering and layout for characters C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UkoeHB @alice-i-cecile @MiniaczQ