Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remnant EntityHash and related types from bevy_utils #15039

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Remove remnant EntityHash and related types from bevy_utils #15039

merged 3 commits into from
Sep 9, 2024

Conversation

ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented Sep 4, 2024

Objective

EntityHash and related types were moved from bevy_utils to bevy_ecs in #11498, but seemed to have been accidentally reintroduced a week later in #11707.

Solution

Remove the old leftover code.

Migration Guide

  • Uses of bevy::utils::{EntityHash, EntityHasher, EntityHashMap, EntityHashSet} now have to be imported from bevy::ecs::entity.

@ItsDoot ItsDoot added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Utils Utility functions and types S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 4, 2024
@ItsDoot ItsDoot added this to the 0.15 milestone Sep 4, 2024
@ItsDoot ItsDoot added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Sep 4, 2024
tychedelia
tychedelia approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty i've been running into this constantly and was confused why

bushrat011899
bushrat011899 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky EntityHashMap clearly didn't want to leave bevy_utils!

@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 4, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 9, 2024
Merged via the queue into bevyengine:main with commit e939d6c Sep 9, 2024
27 checks passed
@ItsDoot ItsDoot deleted the fix/remove-old-entity-hash branch September 9, 2024 16:02
@bevyengine bevyengine deleted a comment from Mcxxxxm Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
4 participants
@ItsDoot @bushrat011899 @tychedelia @alice-i-cecile