Implement ReadOnlyQueryData
for Parent
and Children
#15049
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Parent
andChildren
in queries.Solution
Add an implementation of
ReadOnlyQueryData
(and the prerequisite traits) forParent
andChildren
. This does not conflict with the derived implementations fromComponent
, allowing the wrapping types to still be accessed via&T
and&mut T
as currently.Testing
Showcase
Before
After
As can be seen above, the change in end-user code is minimal, but positive. It's unfortunate that it requires an
unsafe
implementation since we're able to delegate all the actually unsafe operations to the known-safe derived implementation fromComponent
. But I think it's worth it for this (mild) improvement.