Node::is_empty
#15050
Merged
Node::is_empty
#15050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with the `is_empty` method
ickshonpe
added
D-Trivial
IQuick143
approved these changes
Sep 5, 2024
| @@ -698,7 +698,7 @@ pub fn extract_uinode_text( | |||
| }; | |||
|
|
|||
| // Skip if not visible or if size is set to zero (e.g. when a parent is set to `Display::None`) | |||
| if !view_visibility.get() || uinode.size().x == 0. || uinode.size().y == 0. { | |||
| if !view_visibility.get() || uinode.is_empty() { | |||
There was a problem hiding this comment.
I assume the change in behaviour to nodes with negative extents is intentional?
There was a problem hiding this comment.
Taffy clamps the layout size to zero or greater, so there shouldn't be any difference between == or <=. Using <= in the is_empty seemed a safer defensive choice though.
|
I assume NaN values need not be handled because it shouldn't even enter the code. (Else it would be good to revise the logic due to how NaN fails all comparisons.) |
That's right, we shouldn't ever encounter any NaNs here. |
IQuick143
added
the
S-Needs-Review
alice-i-cecile
approved these changes
Sep 5, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add a
Node::is_emptymethod to replace theuinode.size().x() <= 0. || uinode.size.y() <= 0.checks.