-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(readme): enhance warning #15076
Conversation
Don’t know if this readme is included in any of our docs, but if it is, this will trip up cargo doc, as it will parse it as a hyperlink FYI |
This is just the deafult README.md with the "WARNING" message being replaced. |
I know :) You can do |
Could you give me the link to the docs where the README is present |
I tested this on other markdown renderers, and there doesn't seem to be any other place than github that renders it. |
Sure! LWIM uses this technique: Yeah, GitHub is the only place that accepts the |
There seems to be some confusion here. This PR is for the README.md in this repo. |
As I said, I don't think Bevy includes the readme anywhere. LWIM is just an example of how it would look like if it did. |
Oh, i'm so sorry, ill see if i find anything. |
crates.io render the readme too: https://crates.io/crates/bevy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like using these new annotations. They're prettier and easier on the eyes.
Assuming this README isn't used as documentation on docs.rs or any other renderer, I think we should be fine to use this.
Just a couple typos/suggestions.
I've gone ahead and fixed the type ( I tried to short it down, but let me know if i should use the original. |
@SludgePhD, do you know if crates.io can render alerts? |
I don't know, but they are a non-standard feature that isn't supported by most standard markdown engines, so if I had to guess I'd say no. |
Is there any way of excluding it from the crates.io readme? |
I don't think so. The only thing you can do is to have two readmes, maybe one of them generated from the other to reduce duplication. Too much hassle for this minor change for sure. Or you could remove the crates.io readme entirely. |
Or set up the |
The warning could link to the github readme, or (if its possibly) link to the warning alert in the github readme |
the warning could link to a link like this (not rick roll btw) https://arc.net/l/quote/bvslnemh as you can see the warning gets highlighted |
Closed because of crates.io. |
This PR enhances the README.md by replacing the old warning with a warning that looks nicer.
Before:
After: