Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error link #15082

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Fix error link #15082

merged 1 commit into from
Sep 8, 2024

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Sep 7, 2024

Objective

A previous issue describes the same problem: #14248.

This particular link was seemingly missed by #14276.

Solution

  • Search repo for bevyengine.org/learn/errors/#
  • Remove #
  • Verify link goes to right place

@TrialDragon TrialDragon added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 7, 2024
TrialDragon
TrialDragon approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@TrialDragon TrialDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is the only one that I could find via ripgrep, so it covers the last of this issue.

@TrialDragon TrialDragon added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 7, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 8, 2024
Merged via the queue into bevyengine:main with commit 0a79a0a Sep 8, 2024
31 checks passed
BD103 pushed a commit to BD103/bevy that referenced this pull request Sep 9, 2024
@rparrett @BD103
Fix error link (bevyengine#15082)
2612378 
# Objective

A previous issue describes the same problem: bevyengine#14248.

This particular link was seemingly missed by bevyengine#14276.

## Solution

- Search repo for `bevyengine.org/learn/errors/#`
- Remove `#`
- Verify link goes to right place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrialDragon TrialDragon TrialDragon approved these changes

Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rparrett @TrialDragon @alice-i-cecile