Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment in example #15096

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Fix comment in example #15096

merged 1 commit into from
Sep 8, 2024

Conversation

AlexanderStein
Copy link
Contributor

Commit 65252bb (Consistently use PI to specify angles in examples. (#5825)) changed from using push_children to add_child without adjusting the comment

Objective

  • Fix the comments to align with the code

Fix comment in example
eab4604 
Commit 65252bb (Consistently use `PI` to specify angles in examples.
(bevyengine#5825)) changed from using push_children to add_child without
adjusting the comment
@IQuick143 IQuick143 added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 8, 2024
mockersf
mockersf approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be interesting to mention in docs that push_children is the plural version of add_child, or improve naming

@alice-i-cecile
Copy link
Member

Yeah, I'd prefer to improve the naming. Another PR though!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 8, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 8, 2024
Merged via the queue into bevyengine:main with commit bbecc05 Sep 8, 2024
31 of 32 checks passed
@alice-i-cecile alice-i-cecile mentioned this pull request Sep 8, 2024
Closed
BD103 pushed a commit to BD103/bevy that referenced this pull request Sep 9, 2024
@AlexanderStein @BD103
Fix comment in example (bevyengine#15096)
04c40ed 
Commit 65252bb (Consistently use `PI` to specify angles in examples.
(bevyengine#5825)) changed from using push_children to add_child without adjusting
the comment

# Objective

- Fix the comments to align with the code

Co-authored-by: Alexander Stein <alexander.stein@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@IQuick143 IQuick143 IQuick143 approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexanderStein @alice-i-cecile @mockersf @IQuick143