Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
run_system_cached
API will reject systems created bypipe
andmap
#15373run_system
API #14920 (comment)Solution
IntoSystem::pipe
andIntoSystem::map
return two new (possibly-ZST) types that implementIntoSystem
and whoseinto_system
method return the systems that were previously being returned byIntoSystem::pipe
andIntoSystem::map
IntoSystem::into_system
on the argument given toRunSystemCachedWith::new
to avoid losing its ZST-nessTesting
Migration Guide
IntoSystem::pipe
andIntoSystem::map
now returnIntoPipeSystem
andIntoAdapterSystem
instead ofPipeSystem
andAdapterSystem
. Most notably these types don't implementSystem
but rather onlyIntoSystem
.