Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark text colors fix #15794

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Dark text colors fix #15794

merged 4 commits into from
Oct 9, 2024

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Oct 9, 2024 •
edited
Loading

Objective

Fix the text colors.

fixes #15788

Solution

Add the missing corner flags.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 9, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 9, 2024
bushrat011899
bushrat011899 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows 10, can confirm the text is white and works as expected. Unable to test of MacOS to confirm if the issue itself is resolved though.

@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 9, 2024
@rparrett
Copy link
Contributor

rparrett commented Oct 9, 2024

Seems to fix the issue on macos.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 9, 2024
Merged via the queue into bevyengine:main with commit 15072d7 Oct 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@rparrett rparrett Awaiting requested review from rparrett

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

Text is the wrong color
4 participants
@ickshonpe @rparrett @bushrat011899 @alice-i-cecile