examples(shaders/glsl): Update GLSL Shader Example Camera View uniform #15865
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Custom Material GLSL shader example had what seemed to be an old version of the camera view uniform. I was running into issues using camera world position and someone in discord pointed me to the source of truth. crates/bevy_render/src/view/view.wgsl Since this was helpful to me I've updated the shader example to have the latest view uniform structure converted to GLSL. I tested it with: ```bash cargo run --features shader_format_glsl --example shader_material_glsl ```
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
A-Rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The Custom Material GLSL shader example has old version of the camera view uniform structure.
This pr updates the example GLSL custom material shader to have the latest structure.
Solution
I was running into issues using the camera world position (it wasn't changing) and someone in discord pointed me to the source of truth.
crates/bevy_render/src/view/view.wgslAfter using this latest uniform structure in my project i'm not able to work with the camera position in my shader.
Testing
I tested this change by running the example with: