Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gizmo draw order in 2D #9129

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

tim-blackbird
Copy link
Contributor

Objective

Gizmos are intended to draw over everything but for some reason I set the sort key to 0 during #8427 :v

I didn't catch this mistake because it still draws over sprites with a Z translation of 0.

Solution

Set the sort key to f32::INFINITY.

@Selene-Amanita Selene-Amanita added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen A-Gizmos Visual editor and debug gizmos labels Jul 12, 2023
@nerdachse
Copy link

Would be awesome if this could be part of 0.11.1

@james7132 james7132 added this to the 0.11.1 milestone Jul 15, 2023
@james7132 james7132 added this pull request to the merge queue Jul 15, 2023
Merged via the queue into bevyengine:main with commit 7345766 Jul 15, 2023
24 checks passed
cart pushed a commit that referenced this pull request Aug 10, 2023
# Objective

Gizmos are intended to draw over everything but for some reason I set
the sort key to `0` during #8427 :v

I didn't catch this mistake because it still draws over sprites with a Z
translation of `0`.

## Solution

Set the sort key to `f32::INFINITY`.
@tim-blackbird tim-blackbird deleted the fix-gizmo-draw-order branch August 17, 2023 22:04
@cart cart mentioned this pull request Oct 13, 2023
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gizmos Visual editor and debug gizmos A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants