Merge _Reflect
and _WithRegistry
commands
#9680
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
While code was already effectively deduplicated, this further deduplicates it, by removing
InsertReflect
andRemoveReflect
, since they were just specialized version of their_WithRegistry
counterparts.Solution
ReadTypeRegistry
trait, implemented forAsRef<TypeRegistry>
andAppTypeRegistry
ReflectCommandExt
insert_reflect
andremove_reflect
methodsInsertReflect
andRemoveReflect
in favor ofInsertReflectWithRegistry<AppTypeRegistry>
and equivalent.