Remove z-axis scaling in extract_text2d_sprite
#9733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only be applied to the x and y axes but previously it was also applied to the z axis. This commit removes the scaling in the z axis.
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Sep 9, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
rparrett
approved these changes
Sep 11, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
# Objective I noticed this while testing #9733. It's not causing any problems, but we shouldn't teach users to scale 2d stuff in z. ## Solution Only scale in x and y.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective In `extract_text2d_sprite` the scaling by the scale factor should be only be applied to the x and y axes but it's also applied to the z axis. # Solution Remove the scaling in the z axis
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective I noticed this while testing bevyengine#9733. It's not causing any problems, but we shouldn't teach users to scale 2d stuff in z. ## Solution Only scale in x and y.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
In
extract_text2d_spritethe scaling by the scale factor should be only be applied to the x and y axes but it's also applied to the z axis.Solution
Remove the scaling in the z axis