Simplify the display_and_visibility example #9738
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Address #9735 by removing the level of nesting and simplifying the example.
Also added some comments
fixes #9735
Solution
Use
commands.entity(entity).add_child()
instead ofwith_children
in order to remove the level of nesting and to be able to work with loops.TODO
I have two remaining problems with this PR that I wasn't able to fix (and i need help on them):