docs: add comments explaining why we ignore cp errors

bevyengine · Mar 13, 2024 · ce43249 · ce43249
1 parent d36a344
commit ce43249
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -42,7 +42,7 @@ jobs:
  - name: Prepare package
  run: |
  wasm-bindgen --no-typescript --out-name bevy_game --out-dir wasm --target web target/wasm32-unknown-unknown/release/${{ env.binary }}.wasm
- cp -r assets wasm/ || true
+ cp -r assets wasm/ || true # Try to copy, but ignore if it can't copy if source directory does not exist 
 
  - name: Package as a zip
  working-directory: ./wasm
@@ -91,7 +91,7 @@ jobs:
  run: |
  mkdir linux
  cp target/x86_64-unknown-linux-gnu/release/${{ env.binary }} linux/
- cp -r assets linux/ || true
+ cp -r assets linux/ || true # Try to copy, but ignore if it can't copy if source directory does not exist
 
  - name: Package as a zip
  working-directory: ./linux
@@ -137,7 +137,7 @@ jobs:
  run: |
  mkdir windows
  cp target/x86_64-pc-windows-msvc/release/${{ env.binary }}.exe windows/
- mkdir assets -ea 0
+ mkdir assets -ea 0 # create the assets directory if it does not exist, it will get ignored in the zip if empty
  cp -r assets windows/
 
  - name: Package as a zip
@@ -187,7 +187,7 @@ jobs:
  run: |
  mkdir -p ${{ env.binary }}.app/Contents/MacOS
  cp target/x86_64-apple-darwin/release/${{ env.binary }} ${{ env.binary }}.app/Contents/MacOS/
- cp -r assets ${{ env.binary }}.app/Contents/MacOS/ || true
+ cp -r assets ${{ env.binary }}.app/Contents/MacOS/ || true # Try to copy, but ignore if it can't copy if source directory does not exist
  hdiutil create -fs HFS+ -volname "${{ env.binary }}" -srcfolder ${{ env.binary }}.app ${{ env.binary }}-macOS-intel.dmg
 
  - name: Upload binaries to artifacts
@@ -233,7 +233,7 @@ jobs:
  run: |
  mkdir -p ${{ env.binary }}.app/Contents/MacOS
  cp target/aarch64-apple-darwin/release/${{ env.binary }} ${{ env.binary }}.app/Contents/MacOS/
- cp -r assets ${{ env.binary }}.app/Contents/MacOS/ || true
+ cp -r assets ${{ env.binary }}.app/Contents/MacOS/ || true # Try to copy, but ignore if it can't copy if source directory does not exist
  hdiutil create -fs HFS+ -volname "${{ env.binary }}-macOS-apple-silicon" -srcfolder ${{ env.binary }}.app ${{ env.binary }}-macOS-apple-silicon.dmg
 
  - name: Upload binaries to artifacts