Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize resources alphabetically in the rights system according to template translation #330

Conversation

maxime9446
Copy link

When you translate a model from its Filament resource:

public static function getModelLabel(): string { return __('key'); }
This results in updating the labels of sections on the resources permissions page and sorting them alphabetically.

Capture d’écran du 2024-02-08 17-21-01

@bezhanSalleh
Copy link
Owner

Could you revert the code formatting changes and push again. Cause right now I cannot differentiate between the added/updated feature and what was before from this pull request. Thanks.

@maxime9446
Copy link
Author

is it good?

@bezhanSalleh
Copy link
Owner

Now, i can see what you are trying to achive but i'm not going to merge this with the current implementation because of the two map operations it will have a performance cost specially when you have more than 10 models. will add it to the todo list for now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants