Remove double-pluralization from getAllResourcePermissions

[dissto]

Problem

getAllResourcePermissions() is currently running the already pluralized Resource::getPluralModelLabel() through ->plural() again which causes issues in non-english languages. See the german example below.

->prepend(
    str($resourceEntity['fqcn']::getPluralModelLabel())
        ->plural()
        ->title()
        ->append(' - ')
        ->toString()

Example

German example:

Singular	Plural	Expected output	Actual output
Kunde	Kunden	Kunden ✅	Kundens ❌
Lieferant	Lieferanten	Lieferanten ✅	Lieferantens ❌

English example:

Singular	Plural	Expected output	Actual output
Customer	Customers	Customers ✅	Customers ✅
User	Users	Users ✅	Users ✅

Fix

The fix seems to be straight forward since Filament internally already properly pluralizes the getPluralModelLabel()

  ->prepend(
      str($resourceEntity['fqcn']::getPluralModelLabel())
-         ->plural()
          ->title()
          ->append(' - ')
          ->toString()

Reference

Before

After

[what-the-diff]

PR Summary

• Improvement in Resource Permission Function
  The changes made help to simplify the process of identifying resources. Previously, a function was including an unnecessary step where it tried to change the name of a resource to its plural form. This has now been removed improving the efficiency of the function.