mock tests: is it supposed to work like that? #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I kinda like it even, but what is the point of this beautiful but over engineered system? May I replace it with just `b2 -n | FileCheck expected` maybe? It would be much easier to maintain and work with while also faster to run. The only benefit of the current system is unordered match, it not used extensively though and actually confusing. When you finally see the error message good luck to figure out what changed.
|
I would be rather happy if the whole mock thing went away. I didn't write the thing. And I can't think of a time when it detected a problem. I would prefer more low level / isolated unit tests. |
Because it currently tests popular toolsets (except clang-vxworks) which are also tested in CI. It's much more useful for toolsets which can't be tested in CI, would save me from overthinking whether my change could break some rotting without CI toolset. It also tests only a tiny specific scenario. I once wanted to deal with #118 using mocking, but currently it drains too much time to set the tests up (and it also slow to run). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kinda like it even, but what is the point of this beautiful but over engineered system? May I replace it with just
b2 -n | FileCheck expectedmaybe? It would be much easier to maintain and work with while also faster to run. The only benefit of the current system is unordered match, it not used extensively though and actually confusing. When you finally see the error message good luck to figure out what changed.