Add support to logo images found in new mediatek devices. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…88 instead of rbg565. To distinguish between logo versions there is a little difference in the header. I have found that versions using rgb565 contains the word "LOGO" in capital letters, while ones using bgra8888 use lowercase. I have tested it only in a few devices, so if there are exceptions to that rule the scripts will need to be corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I am Teknosrp from xdadevelopers. A few months ago I wrote on your unpack/repack scripts thread about updating the scripts to support new logo images which use different color depth, and you asked me for submitting a pull request with the changes.
I have been busy and finally I had some free time, so I modified the scripts to support these new logo images while maintaining retrocompatibility. They seem to work properly, so now I'm trying to make the pull request. It's the first time that I'm using Git, so I hope I have done it correctly and I can start contributing to other projects.
Many thanks for your time and I wait for your answer.