-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Aave v2 cap adapters for stables #19
Conversation
Co-authored-by: Andrey <kyzia.ru@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to put about DPI on readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but please include a diff snapshot on the tests.
Last time we only noticed a misconfiguration after deployment, because on diff-snapshot the price changed unintendedly. Better this time we check before deployment.
function _deploy() internal returns (address) { | ||
AaveV2EthereumPayload.Adapters memory adapters; | ||
|
||
adapters.usdtAdapter = GovV3Helpers.deployDeterministic( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine, but a bit weird to use GovV3Helpers.deployDeterministic
here - it's just a wrapper around create2utils with a static salt.
Price cap adapters for stablecoins on Aave V2.