Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Aave v2 cap adapters for stables #19

Merged
merged 12 commits into from
Apr 18, 2024
Merged

feat: Aave v2 cap adapters for stables #19

merged 12 commits into from
Apr 18, 2024

Conversation

rustboyar
Copy link
Contributor

Price cap adapters for stablecoins on Aave V2.

Copy link
Contributor

@kyzia551 kyzia551 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to put about DPI on readme

Copy link

@sakulstra sakulstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but please include a diff snapshot on the tests.
Last time we only noticed a misconfiguration after deployment, because on diff-snapshot the price changed unintendedly. Better this time we check before deployment.

function _deploy() internal returns (address) {
AaveV2EthereumPayload.Adapters memory adapters;

adapters.usdtAdapter = GovV3Helpers.deployDeterministic(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, but a bit weird to use GovV3Helpers.deployDeterministic here - it's just a wrapper around create2utils with a static salt.

@rustboyar rustboyar merged commit 3ba71bb into main Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants