DRAFT: Refactoring in extensions style #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Foundry report forge 0.2.0 (62def0d 2024-08-16T00:20:50.128464357Z)Build logCompiling 400 files with Solc 0.8.20
Solc 0.8.20 finished in 103.52s
Compiler run successful with warnings:
Warning (2519): This declaration shadows an existing declaration.
--> tests/periphery/static-a-token/ERC20AaveLMUpgradable.t.sol:398:34:
|
398 | function _fund(uint256 amount, address user) internal {
| ^^^^^^^^^^^^
Note: The shadowed declaration is here:
--> tests/periphery/static-a-token/ERC20AaveLMUpgradable.t.sol:57:3:
|
57 | address public user;
| ^^^^^^^^^^^^^^^^^^^
Warning (2519): This declaration shadows an existing declaration.
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:457:44:
|
457 | function _fundUnderlying(uint256 assets, address user) internal {
| ^^^^^^^^^^^^
Note: The shadowed declaration is here:
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:31:3:
|
31 | address public user;
| ^^^^^^^^^^^^^^^^^^^
Warning (2519): This declaration shadows an existing declaration.
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:461:40:
|
461 | function _fundAToken(uint256 assets, address user) internal {
| ^^^^^^^^^^^^
Note: The shadowed declaration is here:
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:31:3:
|
31 | address public user;
| ^^^^^^^^^^^^^^^^^^^
Warning (2519): This declaration shadows an existing declaration.
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:469:38:
|
469 | function _fund4626(uint256 assets, address user) internal returns (uint256) {
| ^^^^^^^^^^^^
Note: The shadowed declaration is here:
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:31:3:
|
31 | address public user;
| ^^^^^^^^^^^^^^^^^^^
Warning (2519): This declaration shadows an existing declaration.
--> tests/periphery/static-a-token/TestBase.sol:82:44:
|
82 | function _fundUnderlying(uint256 assets, address user) internal {
| ^^^^^^^^^^^^
Note: The shadowed declaration is here:
--> tests/periphery/static-a-token/TestBase.sol:24:3:
|
24 | address public user;
| ^^^^^^^^^^^^^^^^^^^
Warning (2519): This declaration shadows an existing declaration.
--> tests/periphery/static-a-token/TestBase.sol:86:40:
|
86 | function _fundAToken(uint256 assets, address user) internal {
| ^^^^^^^^^^^^
Note: The shadowed declaration is here:
--> tests/periphery/static-a-token/TestBase.sol:24:3:
|
24 | address public user;
| ^^^^^^^^^^^^^^^^^^^
Warning (2519): This declaration shadows an existing declaration.
--> tests/periphery/static-a-token/TestBase.sol:94:38:
|
94 | function _fund4626(uint256 assets, address user) internal returns (uint256) {
| ^^^^^^^^^^^^
Note: The shadowed declaration is here:
--> tests/periphery/static-a-token/TestBase.sol:24:3:
|
24 | address public user;
| ^^^^^^^^^^^^^^^^^^^
Warning (5740): Unreachable code.
--> src/periphery/contracts/dependencies/openzeppelin/ReentrancyGuard.sol:61:5:
|
61 | _status = _NOT_ENTERED;
| ^^^^^^^^^^^^^^^^^^^^^^
Warning (2072): Unused local variable.
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:334:5:
|
334 | uint256 assetsUsedForMinting = erc4626Upgradeable.mint(shares + 1, receiver);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning (2072): Unused local variable.
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:403:5:
|
403 | uint256 shares = _fund4626(assets, user);
| ^^^^^^^^^^^^^^
Warning (2018): Function state mutability can be restricted to pure
--> tests/periphery/static-a-token/ERC20AaveLMUpgradable.t.sol:88:3:
|
88 | function test_2701() external view {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (2018): Function state mutability can be restricted to pure
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:49:3:
|
49 | function test_2701() external view {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (2018): Function state mutability can be restricted to pure
--> tests/periphery/static-a-token/ERC4626StataTokenUpgradeable.t.sol:451:3:
|
451 | function _setupTestEnv(uint256 amount) internal returns (TestEnv memory) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (2018): Function state mutability can be restricted to view
--> tests/periphery/static-a-token/StataTokenV2Pausable.t.sol:10:3:
|
10 | function test_canPause() external {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (2018): Function state mutability can be restricted to view
--> tests/periphery/static-a-token/StataTokenV2Pausable.t.sol:14:3:
|
14 | function test_canPause_shouldReturnFalse(address actor) external {
| ^ (Relevant source part starts here and spans across multiple lines).Test error
|
❌
eboadom
reviewed
Aug 14, 2024
| bytes32 private constant Stata4626StorageLocation = | ||
| 0x4865e395e8f896b2ca01e8489fd809975f6c70c69fd3d1cf5d2263a21a649200; | ||
| // keccak256(abi.encode(uint256(keccak256("aave-dao.storage.ERC4626StataToken")) - 1)) & ~bytes32(uint256(0xff)) | ||
| bytes32 private constant ERC4626StataTokenStorageLocation = |
eboadom
reviewed
Aug 14, 2024
src/periphery/contracts/static-a-token/ERC4626StataTokenUpgradeable.sol
Outdated
Show resolved
Hide resolved
eboadom
reviewed
Aug 14, 2024
| assetToDeposit.permit(_msgSender(), address(this), assets, deadline, sig.v, sig.r, sig.s) | ||
| {} catch {} | ||
|
|
||
| return depositToAave ? deposit(assets, receiver) : depositATokens(assets, receiver); |
There was a problem hiding this comment.
Why instead of internal? Seems unnecessary duplication
Changes on stata initializations, to follow more strict guidelines
Feat/improved tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.