Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added example for setting up new emissions per second and distribution end #4

Merged
merged 12 commits into from
Jun 26, 2023
Merged

feat: added example for setting up new emissions per second and distribution end #4

merged 12 commits into from
Jun 26, 2023

Conversation

brotherlymite
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 5, 2023 •
edited
Loading

Foundry report

forge 0.2.0 (388c3c0 2023-04-10T00:12:13.189631296Z)
Build log 
installing solc version "0.8.10"
Successfully installed solc 0.8.10
installing solc version "0.8.19"
Successfully installed solc 0.8.19
Compiling 36 files with 0.8.10
Compiling 41 files with 0.8.19
Solc 0.8.10 finished in 2.20s
Solc 0.8.19 finished in 3.80s
Compiler run successful
| Contract                       | Size (kB) | Margin (kB) |
|--------------------------------|-----------|-------------|
| AaveV3Optimism                 | 0.086     | 24.49       |
| AaveV3OptimismAssets           | 0.086     | 24.49       |
| AaveV3Polygon.0.8.10           | 0.086     | 24.49       |
| AaveV3Polygon.0.8.19           | 0.086     | 24.49       |
| AaveV3PolygonAssets.0.8.10     | 0.086     | 24.49       |
| AaveV3PolygonAssets.0.8.19     | 0.086     | 24.49       |
| AddEmissionAdminPayload.0.8.10 | 0.487     | 24.089      |
| AddEmissionAdminPayload.0.8.19 | 0.487     | 24.089      |
| ConfiguratorInputTypes.0.8.10  | 0.086     | 24.49       |
| ConfiguratorInputTypes.0.8.19  | 0.086     | 24.49       |
| DataTypes.0.8.10               | 0.086     | 24.49       |
| DataTypes.0.8.19               | 0.086     | 24.49       |
| GPv2SafeERC20                  | 0.086     | 24.49       |
| MockExecutor                   | 0.437     | 24.139      |
| PullRewardsTransferStrategy    | 1.316     | 23.26       |
| RewardsDataTypes.0.8.10        | 0.086     | 24.49       |
| RewardsDataTypes.0.8.19        | 0.086     | 24.49       |
| console.0.8.10                 | 0.086     | 24.49       |
| console.0.8.19                 | 0.086     | 24.49       |
| console2.0.8.10                | 0.086     | 24.49       |
| console2.0.8.19                | 0.086     | 24.49       |
| stdError                       | 0.591     | 23.985      |
| stdJson.0.8.10                 | 0.086     | 24.49       |
| stdJson.0.8.19                 | 0.086     | 24.49       |
| stdMath.0.8.10                 | 0.086     | 24.49       |
| stdMath.0.8.19                 | 0.086     | 24.49       |
| stdStorage.0.8.10              | 0.086     | 24.49       |
| stdStorage.0.8.19              | 0.086     | 24.49       |
| stdStorageSafe.0.8.10          | 0.086     | 24.49       |
| stdStorageSafe.0.8.19          | 0.086     | 24.49       |
Test error :finnadie:❌ 
No files changed, compilation skipped
�[2m2023-04-10T07:09:11.571224Z�[0m �[31mERROR�[0m �[2msharedbackend�[0m�[2m:�[0m Failed to send/recv `basic` �[3merr�[0m�[2m=�[0mGetAccount(0xaad324f7e4dd50c6b105820f8a877ee2dcbfa789, 
�[31mDeserialization Error: expected value at line 1 column 1. Response: <html><body><h1>429 Too Many Requests</h1>
You have sent too many requests in a given amount of time.
</body></html>
�[0m) �[3maddress�[0m�[2m=�[0m0xaad324f7e4dd50c6b105820f8a877ee2dcbfa789

Running 1 test for tests/EmissionTestOpOptimism.t.sol:EmissionTestOpOptimism
�[31m[FAIL. Reason: EvmError: FatalExternalError]�[0m test_activation() (gas: 9223372036854754743)
Test result: �[31mFAILED�[0m. 0 passed; 1 failed; finished in 752.52ms

Running 2 tests for tests/EmissionConfigurationTestMATICXPolygon.t.sol:EmissionConfigurationTestMATICXPolygon
�[32m[PASS]�[0m test_setNewDistributionEnd() (gas: 149165)
Logs:
  calldata to execute tx on EMISSION_MANAGER to set the new distribution end from the emissions admin (safe): 0xc5a7b5380000000000000000000000004a1c3ad6ed28a636ee1751c69071f6be75deb8b8000000000000000000000000fa68fb4628dff1028cfec22b4162fccd0d45efb600000000000000000000000000000000000000000000000000000000643cefa7

�[32m[PASS]�[0m test_setNewEmissionPerSecond() (gas: 158261)
Logs:
  calldata to execute tx on EMISSION_MANAGER to set the new emission per second from the emissions admin (safe): 0xf996868b0000000000000000000000004a1c3ad6ed28a636ee1751c69071f6be75deb8b8000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000001000000000000000000000000fa68fb4628dff1028cfec22b4162fccd0d45efb600000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000006da6d2fa1aca4

Test result: �[32mok�[0m. 2 passed; 0 failed; finished in 1.92s

Running 1 test for tests/EmissionTestSDPolygon.t.sol:EmissionTestSDPolygon
�[32m[PASS]�[0m test_activation() (gas: 556663)
Logs:
  calldata to submit from Gnosis Safe: 0x955c2ad700000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000001287f82296729100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000064cf5a5300000000000000000000000080ca0d8c38d2e2bcbab66aa1648bd1c7160500fe0000000000000000000000001d734a02ef1e1f5886e66b0673b71af5b53ffa94000000000000000000000000c51e6e38d406f98049622ca54a6096a23826b42600000000000000000000000030e9671a8092429a358a4e31d41381aa0d10b0a0

Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 3.59s

Running 1 test for tests/EmissionTestMATICXPolygon.t.sol:EmissionTestMATICXPolygon
�[32m[PASS]�[0m test_activation() (gas: 414568)
Logs:
  calldata to submit from Gnosis Safe: 0x955c2ad700000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000db4da5f43594800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000064db93540000000000000000000000004a1c3ad6ed28a636ee1751c69071f6be75deb8b8000000000000000000000000fa68fb4628dff1028cfec22b4162fccd0d45efb600000000000000000000000053f57eaad604307889d87b747fc67ea9de430b010000000000000000000000005d37e4b374e6907de8fc7fb33ee3b0af403c7403

Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 3.13s

Running 1 test for tests/EmissionTestSTMATICPolygon.t.sol:EmissionTestSTMATICPolygon
�[32m[PASS]�[0m test_activation() (gas: 414568)
Logs:
  calldata to submit from Gnosis Safe: 0x955c2ad700000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000db4da5f43594800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000064db93540000000000000000000000004a1c3ad6ed28a636ee1751c69071f6be75deb8b80000000000000000000000003a58a54c066fdc0f2d55fc9c89f0415c92ebf3c400000000000000000000000053f57eaad604307889d87b747fc67ea9de430b0100000000000000000000000097371df4492605486e23da797fa68e55fc38a13f

Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 1.28s

Failing tests:
Encountered 1 failing test in tests/EmissionTestOpOptimism.t.sol:EmissionTestOpOptimism
�[31m[FAIL. Reason: EvmError: FatalExternalError]�[0m test_activation() (gas: 9223372036854754743)

Encountered a total of �[31m1�[0m failing tests, �[32m5�[0m tests succeeded

@eboadom
Copy link
Contributor

eboadom commented Apr 5, 2023

I would better pin to a current block on Polygon (where LM is active), to skip the setup steps that are not required for both changing emissions and changing the distribution end

eboadom
eboadom reviewed May 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
eboadom
eboadom reviewed May 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
eboadom
eboadom reviewed May 23, 2023
View reviewed changes
README.md Show resolved Hide resolved
eboadom
eboadom reviewed May 23, 2023
View reviewed changes
README.md Show resolved Hide resolved
eboadom
eboadom reviewed May 23, 2023
View reviewed changes
README.md Show resolved Hide resolved
@brotherlymite brotherlymite merged commit a9b7d36 into main Jun 26, 2023
1 check failed
@brotherlymite brotherlymite deleted the feat/configure-emissions branch June 26, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboadom eboadom eboadom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brotherlymite @eboadom