Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick patch for the solution for issue #19 #20

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mhoangvslev
Copy link
Contributor

  • When the exception is thrown, the database rollbacks to the previous state, but no longer block users from executing the next queries.

  • If user performs queries other than SELECT, the transaction will be committed if no error thrown.

- When the exception is thrown, the database rollbacks to the previous state, but no longer block users from executing the next queries.

- If user performs queries other than SELECT, the transaction will be committed if no error thrown.
Copy link
Owner

@bgschiller bgschiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the difference between { 'status': 'abort' } and { 'status': 'error' }, and I think I'd prefer not to have autocommit implemented this way.

postgres_kernel/kernel.py Show resolved Hide resolved
postgres_kernel/kernel.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants