Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions from @josojo #1

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Suggestions from @josojo #1

merged 1 commit into from
Sep 7, 2022

Conversation

bh2smith
Copy link
Owner

@bh2smith bh2smith commented Sep 7, 2022

This PR addresses all of the following comments. cc @josojo

  • I think you should make the steps in the readme easier to follow: e.g. cd dunecon-workshop is missing
  • I think you should encourage everyone to use a venv
  • .env.sample is still empty
  • python -m 1-basic-fetch works super nicely like it!
  • I would put 3-data-modeling.py as the second example. Its much easier and closer to the first example
  • I was not able to execute the second example, as adding a slack bot was quite some overhead. Not sure whether others will try it. maybe sending an email is the easiest example?

For the last part, we updated the open issue in dune-alerts adding AlertLevel.EMAIL as a third possibility.

@bh2smith bh2smith merged commit df047df into main Sep 7, 2022
@bh2smith bh2smith deleted the josojo-suggestions branch September 7, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant