Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace didn't remove experiments from segmentAllocations after invoking RemoveExperiment() #4

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

namespace didn't remove experiments from segmentAllocations after invoking RemoveExperiment() #4

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
749972d
Handle nil values on indexing operations
timwu Oct 12, 2015
83ab4eb
Factor out some test commonality
timwu Oct 12, 2015
34a7125
Formatting
timwu Oct 13, 2015
e70ed1b
clear segmentAllocations after removing an experiment
panjf2000 Jul 18, 2018
61e7d99
optimization for removing experiments
panjf2000 Jul 22, 2018
2663685
fixed issue after removing experiments
panjf2000 Jul 23, 2018
0c8573e
fixed
panjf2000 Jul 23, 2018
50cfdc5
fixed reflect err when userid was uint
panjf2000 Jul 25, 2018
98c9466
update
panjf2000 Jul 26, 2018
8f6bfd5
update
panjf2000 Jul 26, 2018
4c3b650
update
panjf2000 Jul 26, 2018
e29b3b5
optimization
panjf2000 Jul 26, 2018
6c97642
Merge branch 'master' into master
panjf2000 Jul 27, 2018
7f880e3
rename fields to exported for gob encoding
panjf2000 Aug 3, 2018
99a8af2
Merge remote-tracking branch 'origin/master'
panjf2000 Aug 3, 2018
efbe672
update -
panjf2000 Aug 6, 2018
c9817c2
update
panjf2000 Aug 6, 2018
2f29e57
update
panjf2000 Aug 6, 2018
6c68e95
update
panjf2000 Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions namespace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ func (n *SimpleNamespace) RemoveExperiment(name string) error {
}
}

for _, val := range segmentsToFree {
delete(n.segmentAllocations, uint64(val))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could delete be done inside the loop where values are added tosegmentsToFree? (instead of iterating segmentsToFree outside separately)
https://github.com/biased-unit/planout-golang/blob/master/namespace.go#L98

}

for i := range segmentsToFree {
n.availableSegments = append(n.availableSegments, segmentsToFree[i])
}
Expand Down