Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo found by codespell #1811

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.16% ⚠️

Comparison is base (ada255e) 85.74% compared to head (ec3dc64) 83.59%.

❗ Current head ec3dc64 differs from pull request most recent head 658f906. Consider uploading reports for the commit 658f906 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
- Coverage   85.74%   83.59%   -2.16%     
==========================================
  Files         132       92      -40     
  Lines        6728     3895    -2833     
  Branches     1548     1272     -276     
==========================================
- Hits         5769     3256    -2513     
+ Misses        851      541     -310     
+ Partials      108       98      -10     
Files Changed Coverage Δ
bids-validator/validators/tsv/tsv.js 94.19% <ø> (ø)

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

I'm curious why this wasn't found by our codespell action. I also can't find it locally. How did you run codespell to find this?

@Remi-Gau
Copy link
Contributor

maybe worth having a codespell config in the repo rather than just define it in the GHA workflow.

@effigies
Copy link
Collaborator

Agreed, but it would be nice to know the configuration needed to detect this.

@DimitriPapadopoulos
Copy link
Contributor Author

Oh, it's just that I'm using the latest dictionaries (I am currently merging many updates into the dictionaries).

@rwblair rwblair merged commit 6789e4d into bids-standard:master Sep 26, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch September 26, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants