Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Tag deno builds with full version, truncate history #1993

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

effigies
Copy link
Collaborator

We don't have enough git context to properly tag our builds:

deno run -A https://github.com/bids-standard/bids-validator/raw/deno-build/bids-validator.js --version
bids-validator bd30213

This fixes that. We're also pipling 5MB of javascript into each commit of deno-build. Some of it might compress down well enough, but it's unclear what the benefit is of holding onto this history.

The first commit can be used without the second commit, if there's a reason to keep around the history.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (bd30213) to head (c551e07).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
+ Coverage   85.68%   86.86%   +1.18%     
==========================================
  Files          91      132      +41     
  Lines        3792     6351    +2559     
  Branches     1220     1524     +304     
==========================================
+ Hits         3249     5517    +2268     
- Misses        457      743     +286     
- Partials       86       91       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 2db52e8 into bids-standard:master Jun 13, 2024
33 checks passed
@effigies effigies deleted the build/git-history branch June 13, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant