Improve test coverage for code added in #2014 #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2018 +/- ##
==========================================
+ Coverage 85.60% 86.85% +1.24%
==========================================
Files 91 132 +41
Lines 3785 6350 +2565
Branches 1218 1523 +305
==========================================
+ Hits 3240 5515 +2275
- Misses 459 744 +285
- Partials 86 91 +5 ☔ View full report in Codecov by Sentry. |
|
|
effigies
approved these changes
Jul 12, 2024
|
LGTM, but I'll leave to @rwblair to make a final review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a request from @VisLab, this PR adds test coverage to the three lines listed in https://github.com/bids-standard/bids-validator/pull/2014/files/aeee4c1cfd0c3ea5eced14c6b99f69abc89260df..b2024d91d7efb0a1cc183d8f4d1afb4e9fcb94a7 as not having test coverage. This is a follow-on from #2014.