Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsv): Check explicit formats for column contents when defined #2025

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

effigies
Copy link
Collaborator

Resolves a discrepancy between legacy and schema validator. We had been previously validating the type of entries in columns, but not the stated formats, when present.

We now give preference to an explicit format over type checking.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (56734ab) to head (bdf0f4b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2025      +/-   ##
==========================================
+ Coverage   85.75%   87.21%   +1.45%     
==========================================
  Files          91      132      +41     
  Lines        3785     6320    +2535     
  Branches     1218     1526     +308     
==========================================
+ Hits         3246     5512    +2266     
- Misses        453      717     +264     
- Partials       86       91       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwblair rwblair merged commit 93868ab into bids-standard:master Jul 29, 2024
33 checks passed
@effigies effigies deleted the acqtime_fmt branch July 29, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants