Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deno fmt schema validator #2026

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

effigies
Copy link
Collaborator

Separating from other PRs to ensure there are no semantic changes.

I set some parameters that should result in less reformatting overall. I am willing to change any of them.

@effigies effigies requested review from nellh and rwblair July 29, 2024 02:05
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 36 lines in your changes missing coverage. Please review.

Project coverage is 87.19%. Comparing base (f0a2d3d) to head (dd2d7a2).
Report is 1 commits behind head on master.

Files Patch % Lines
bids-validator/src/schema/applyRules.ts 78.57% 26 Missing and 1 partial ⚠️
bids-validator/src/validators/filenameValidate.ts 28.57% 5 Missing ⚠️
bids-validator/src/version.ts 33.33% 2 Missing ⚠️
bids-validator/src/schema/context.ts 50.00% 1 Missing ⚠️
bids-validator/src/setup/loadSchema.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2026      +/-   ##
==========================================
+ Coverage   85.75%   87.19%   +1.43%     
==========================================
  Files          91      132      +41     
  Lines        3785     6308    +2523     
  Branches     1218     1524     +306     
==========================================
+ Hits         3246     5500    +2254     
- Misses        453      717     +264     
- Partials       86       91       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit ee2cb78 into bids-standard:master Jul 29, 2024
29 of 33 checks passed
@effigies effigies deleted the chore/fmt branch July 29, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants