feat(json): Warn on missing RECOMMENDED metadata #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2027 +/- ##
==========================================
+ Coverage 85.75% 87.35% +1.59%
==========================================
Files 91 132 +41
Lines 3785 6325 +2540
Branches 1218 1526 +308
==========================================
+ Hits 3246 5525 +2279
- Misses 453 709 +256
- Partials 86 91 +5 ☔ View full report in Codecov by Sentry. |
|
People seem to ignore warnings as is, but not reporting them is against the spirit of BIDS. I'm neutral either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dramatically increases the number of warnings emitted, since BIDS has been very liberal with its RECOMMENDATIONS.
The alternative is to go add issues to all of the sidecar fields that previously warned.