rf(json-schema): Factor JSON schema validation out of context.dataset #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2033 +/- ##
==========================================
+ Coverage 85.75% 87.09% +1.33%
==========================================
Files 91 134 +43
Lines 3785 6415 +2630
Branches 1218 1545 +327
==========================================
+ Hits 3246 5587 +2341
- Misses 453 738 +285
- Partials 86 90 +4 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
rf/json-validator
branch
from
6fd3b8b to
cc2e890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2020. Feels a bit cleaner to make the Ajv validator a singleton that gets updated once, when the schema is loaded.