Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] Update all npm dependencies (2024-10-31) #2167

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 20, 2024

This is your weekly update of all npm dependencies. Please take a good look at what changed and the test results before merging this pull request.

What changed?

↗️ @next/env (indirect, 14.2.13 → 14.2.15, patch) · Repo · Release

✳️ @next/eslint-plugin-next (14.2.13 → 14.2.15, patch)

✳️ chai (5.1.1 → 5.1.2, patch) · Repo · Changelog · Release · Diff

✳️ eslint-config-next (14.2.13 → 14.2.15, patch)

✳️ hed-validator (3.15.4 → 3.15.5, patch) · Repo · Release · Diff

✳️ next (14.2.13 → 14.2.15, patch) · Repo · Release


Depfu Status

Depfu will only send you the next scheduled PR once you merge or close this one.

All Depfu comment commands
@​depfu refresh
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu depfu bot added the depfu label Oct 20, 2024
@depfu depfu bot assigned effigies Oct 20, 2024
@effigies
Copy link
Collaborator

@happy5214 Just a note that hed-validator 3.15.5 broke the legacy validator. It appears (#2169) to work fine with the schema validator.

I just want to check whether this is intentional, since it was a patch release instead of a minor release.

If the intent going forward is to stop supporting the legacy validator (which is a totally reasonable position to take), it would be good to know, and we'll freeze that dependency. Our hope is to transition the world away from the legacy validator in the coming months, in any case.

@happy5214
Copy link
Collaborator

@happy5214 Just a note that hed-validator 3.15.5 broke the legacy validator. It appears (#2169) to work fine with the schema validator.

I just want to check whether this is intentional, since it was a patch release instead of a minor release.

If the intent going forward is to stop supporting the legacy validator (which is a totally reasonable position to take), it would be good to know, and we'll freeze that dependency. Our hope is to transition the world away from the legacy validator in the coming months, in any case.

No, that was not the intent. It's actually a bug, but in this case, hed-validator is right and both the hed.js and hed.spec.js modules in the legacy validator are wrong.

Long story: The tests have improperly nested HED data in three sidecars (the HED level is the third level, where it should be the second level). This is causing https://github.com/hed-standard/hed-javascript/blob/916236a58b9912cb4fefc0e79aa9c28d0f35cedb/bids/types/json.js#L107 to (correctly) throw an IssueError for what amounts to a SIDECAR_INVALID HED error. However, the try block starting at https://github.com/bids-standard/bids-validator/blob/5646d9dee39eb9228881ec7e57887021cf3072b0/bids-validator/validators/hed.js#L34 incorrectly assumes all caught errors are missing schema errors, leading to improper issue reporting.

The tests need to be fixed to correct the level of HED in the three bad sidecars, and hed.js needs to be re-coded to find another way to deal with a null return from the validation function.

@effigies
Copy link
Collaborator

@​depfu refresh

@depfu depfu bot changed the title [js] Update all npm dependencies (2024-10-20) [js] Update all npm dependencies (2024-10-31) Oct 31, 2024
@depfu depfu bot force-pushed the depfu/batch_all/npm/2024-10-20 branch from 26ac9ad to eaf1f86 Compare October 31, 2024 13:27
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.70%. Comparing base (9d0d585) to head (eaf1f86).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2167   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files          91       91           
  Lines        3784     3784           
  Branches     1221     1221           
=======================================
  Hits         3243     3243           
  Misses        455      455           
  Partials       86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 29cbc5c into master Oct 31, 2024
19 checks passed
@effigies effigies deleted the depfu/batch_all/npm/2024-10-20 branch October 31, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants