-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[js] Update all npm dependencies (2024-10-31) #2167
Conversation
@happy5214 Just a note that hed-validator 3.15.5 broke the legacy validator. It appears (#2169) to work fine with the schema validator. I just want to check whether this is intentional, since it was a patch release instead of a minor release. If the intent going forward is to stop supporting the legacy validator (which is a totally reasonable position to take), it would be good to know, and we'll freeze that dependency. Our hope is to transition the world away from the legacy validator in the coming months, in any case. |
No, that was not the intent. It's actually a bug, but in this case, hed-validator is right and both the Long story: The tests have improperly nested HED data in three sidecars (the The tests need to be fixed to correct the level of |
@depfu refresh |
26ac9ad
to
eaf1f86
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2167 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 91 91
Lines 3784 3784
Branches 1221 1221
=======================================
Hits 3243 3243
Misses 455 455
Partials 86 86 ☔ View full report in Codecov by Sentry. |
This is your weekly update of all npm dependencies. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ @next/eslint-plugin-next (14.2.13 → 14.2.15, patch)
✳️ chai (5.1.1 → 5.1.2, patch) · Repo · Changelog · Release · Diff
✳️ eslint-config-next (14.2.13 → 14.2.15, patch)
✳️ hed-validator (3.15.4 → 3.15.5, patch) · Repo · Release · Diff
✳️ next (14.2.13 → 14.2.15, patch) · Repo · Release
Depfu will only send you the next scheduled PR once you merge or close this one.
All Depfu comment commands