Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Allow blacklisting any modality from schema.rules.modalities #2176

Merged
merged 2 commits into from
Oct 28, 2024

Log a warning if an unknown modality is blacklisted

525163b
Select commit
Loading
Failed to load commit list.
Merged

fix(cli): Allow blacklisting any modality from schema.rules.modalities #2176

Log a warning if an unknown modality is blacklisted
525163b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2024 in 1s

87.48% (+1.75%) compared to f40d4de

View this Pull Request on Codecov

87.48% (+1.75%) compared to f40d4de

Details

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.48%. Comparing base (f40d4de) to head (525163b).

Files with missing lines Patch % Lines
bids-validator/src/validators/bids.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2176      +/-   ##
==========================================
+ Coverage   85.72%   87.48%   +1.75%     
==========================================
  Files          91      133      +42     
  Lines        3784     7055    +3271     
  Branches     1221     1671     +450     
==========================================
+ Hits         3244     6172    +2928     
- Misses        454      788     +334     
- Partials       86       95       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.