[MAINT] remove code climate and update badges #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Remi-Gau
commented
Nov 7, 2024
•
Remi-Gau
commented
- remove code climate config
- update badges in README
- update links to legacy validator in README
Remi-Gau
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2190 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 91 91
Lines 3784 3784
Branches 1221 1221
=======================================
Hits 3243 3243
Misses 455 455
Partials 86 86 ☔ View full report in Codecov by Sentry. |
Remi-Gau
commented
Nov 7, 2024
bids-validator/README.md
Outdated
| @@ -335,6 +350,9 @@ see available options. | |||
|
|
|||
| ## Docker image | |||
|
|
|||
| <!-- TODO update version --> | |||
| **:rotating_light: docker images of the bids-validator used the legacy validator until version 1.X.Y** | |||
There was a problem hiding this comment.
not sure which version of the docker image contains the new validator.
Remi-Gau
commented
Nov 9, 2024
bids-validator/README.md
Outdated
Comment on lines
353
to
355
| <!-- TODO update version --> | ||
| **:rotating_light: at this time (november 2024) docker images of the bids-validator still use the legacy validator. But this should soon change.** | ||
|
|
There was a problem hiding this comment.
changed the wording to let users know that they may still be using the legacy validator if using the docker image
Remi-Gau
commented
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.