test(e2e): use random strings instead of UUID helper

bifravst · Oct 23, 2020 · 4f8da4d · 4f8da4d
1 parent 390dfb5
commit 4f8da4d
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 13 deletions.
diff --git a/feature-runner/run-features.ts b/feature-runner/run-features.ts
@@ -20,7 +20,6 @@ import {
 	WorkGroupName,
 } from '../historicalData/settings'
 import { athenaStepRunners } from './steps/athena'
-import { uuidHelper } from './steps/uuidHelper'
 import { STS, CloudFormation } from 'aws-sdk'
 import { v4 } from 'uuid'
 import { region } from '../cdk/regions'
@@ -152,7 +151,6 @@ program
 					.addStepRunners(athenaStepRunners(world))
 					.addStepRunners(bifravstStepRunners(world))
 					.addStepRunners(firmwareCIStepRunners(world))
-					.addStepRunners([uuidHelper])
 					.addStepRunners(storageStepRunners())
 					.addStepRunners(
 						randomStepRunners({
@@ -167,6 +165,7 @@ program
 											.toString(36)
 											.replace(/[^a-z]+/g, ''),
 									),
+								UUID: (): string => v4(),
 							},
 						}),
 					)

diff --git a/feature-runner/steps/uuidHelper.ts b/feature-runner/steps/uuidHelper.ts
diff --git a/features/FOTA.feature b/features/FOTA.feature
@@ -10,7 +10,7 @@ Feature: Device Firmware Upgrade over the air
   Scenario: Create a new firmware upgrade as a user
 
     Given I am authenticated with Cognito
-    And I store a UUIDv4 as "jobId"
+    Given I have a random UUID in "jobId"
     When I execute "putObject" of the AWS S3 SDK with
        """
         {

diff --git a/features/FirmwareCI.feature b/features/FirmwareCI.feature
@@ -24,7 +24,7 @@ Feature: Schedule CI runs of firmware builds
         This happens for every firmware change
 
         # The job id needs to be unique, do not use the git commit hash
-        Given I store a UUIDv4 as "ciJobId"
+        Given I have a random UUID in "ciJobId"
 
         # Create a pre-signed URL which will be used by the firmware CI
         # runner to store the log output.