Add basic tldraw poll shape rendering #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing poll rendering code for pre-tldraw polls has been copy/ pasted and adjusted slightly to handle the different data structure for the poll response data.
|
Live meeting: annotation includes the [optional] question
Presentation format: again includes the question Video format annotation does not include the title: |
Poll now uses the colors from tldraw for the background, which makes it look more like the poll in the live meeting. Text size and padding is adjusted slightly smaller, since the tldraw shapes end up being kind of small for the amount of text in them. Poll title is rendered at the top of the box if present.
Make the question be bold, to match the live session. Fix the calculation of the title width; poll bars were being rendered at the wrong vertical position because the variable for the reserved height was being overwritten.
|
Updated version of the renderer improves the text size and spacing around bars a bit, and adds support for rendering the poll question if provided. I tried to get the colors a bit closer to the live session, but I'm not totally sure where the colors are coming from there… some of them seem to be hardcoded? The images in bigbluebutton/tldraw#16 show a grey background, but the screenshot in #55 (comment) shows a white background. Here's what the updated poll rendering looks like: I think it's good to be merged at this point - we can always tweak colors and spacing further later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash caused by an unsupported tldraw shape, and renders polls in the correct location and size on the canvas.
The current poll rendering is re-using code that was made for the pre-tldraw whiteboard, so the styling doesn't match the live polls, and the poll title is not shown. Some additional work is still needed to tweak/improve the rendering style.
This fixes #52 and #53