Support multiple controllers paths #213
Open
+37
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I ran into a problem in a Rails app which was made up of multiple Rails engines. The problem was that two engines were using Gruf and when they were used in same Rails app, the Gruf config for
controllers_path
was getting overridden.So to fix that problem, I patched Gruf to support multiple paths for controllers by adding a new config field
controllers_paths
. This field defaults to[controllers_path]
. Gruf uses thiscontrollers_paths
instead ofcontrollers_path
everywhere, butcontrollers_path
is kept in config for backward compatibility.Note: I think the config should support something like
add_controllers_paths
, instead of directly settingcontrollers_paths
. That will allow multiple modules to add their controllers path without messing with the existing paths. Let me know if you like this idea, I will update the PRHow was it tested?
All the specs are passing