Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple controllers paths #213

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

salmanasiddiqui
Copy link

@salmanasiddiqui salmanasiddiqui commented Oct 31, 2024

What? Why?

I ran into a problem in a Rails app which was made up of multiple Rails engines. The problem was that two engines were using Gruf and when they were used in same Rails app, the Gruf config for controllers_path was getting overridden.

So to fix that problem, I patched Gruf to support multiple paths for controllers by adding a new config field controllers_paths. This field defaults to [controllers_path]. Gruf uses this controllers_paths instead of controllers_path everywhere, but controllers_path is kept in config for backward compatibility.

Note: I think the config should support something like add_controllers_paths, instead of directly setting controllers_paths. That will allow multiple modules to add their controllers path without messing with the existing paths. Let me know if you like this idea, I will update the PR

How was it tested?

All the specs are passing

#
def load!(controllers_path:)
controllers(controllers_path: controllers_path)
def load!(controllers_paths:)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @salmanasiddiqui - while this is a good change to support multiple paths, this unfortunately makes a backwards incompatible change here I'd like to avoid.

Can we add this as a new keyword argument, and deprecate the old one (to be removed in gruf 3.0). We should support both syntaxes in 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants