Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add url for AutoACMG (#252) #253

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

gromdimon
Copy link
Collaborator

Added url to urlConfig.

@gromdimon gromdimon linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.98%. Comparing base (74df3b9) to head (e108c62).

Files with missing lines Patch % Lines
src/lib/urlConfig.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   63.99%   63.98%   -0.02%     
==========================================
  Files          57       57              
  Lines        2611     2613       +2     
  Branches      893      893              
==========================================
+ Hits         1671     1672       +1     
- Misses        855      856       +1     
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gromdimon
Copy link
Collaborator Author

Important

Do not implement tests, since urlConfig doesn't have tests at all!

@gromdimon gromdimon merged commit 9a7538a into main Sep 18, 2024
5 of 7 checks passed
@gromdimon gromdimon deleted the 252-add-base-url-for-autoacmg branch September 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add base url for AutoACMG
1 participant