Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Add ReadAlias and SetAlias implementation #146

Merged
merged 2 commits into from
Oct 27, 2024
Merged

server: Add ReadAlias and SetAlias implementation #146

merged 2 commits into from
Oct 27, 2024

Conversation

warusadura
Copy link
Collaborator

@warusadura warusadura commented Oct 24, 2024 •
edited
Loading

No description provided.

bilelmoussaoui
bilelmoussaoui reviewed Oct 24, 2024
View reviewed changes
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/collection.rs Outdated Show resolved Hide resolved
server/src/collection.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
client/src/dbus/error.rs Show resolved Hide resolved
bilelmoussaoui
bilelmoussaoui reviewed Oct 25, 2024
View reviewed changes
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Show resolved Hide resolved
bilelmoussaoui
bilelmoussaoui reviewed Oct 25, 2024
View reviewed changes
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
server/src/service.rs Outdated Show resolved Hide resolved
@warusadura
client: Associate ServiceError variants with String values
999268b 
So, they can take a custom error text.

Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
bilelmoussaoui
bilelmoussaoui reviewed Oct 27, 2024
View reviewed changes
Copy link
Owner

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

@warusadura
server: Add ReadAlias and SetAlias implementation
9364edd 
Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
@bilelmoussaoui bilelmoussaoui merged commit 2f9e037 into bilelmoussaoui:main Oct 27, 2024
7 checks passed
@warusadura warusadura deleted the alias branch October 27, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilelmoussaoui bilelmoussaoui bilelmoussaoui left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warusadura @bilelmoussaoui