Do not take ownership of the attributes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A6GibKm
force-pushed
the
ref-attribute
branch
2 times, most recently
from
85b0f58
to
652745b
Compare
|
Would need a rebase |
bilelmoussaoui
previously approved these changes
Jan 3, 2024
A6GibKm
force-pushed
the
ref-attribute
branch
from
138e676
to
2c127af
Compare
|
Rebased and tested with the CLI utility. |
A6GibKm
changed the title
cli/src/main.rs
Outdated
| @@ -11,7 +11,7 @@ use oo7::{ | |||
| zbus, | |||
| }; | |||
|
|
|||
| const BINARY_NAME: &'static str = env!("CARGO_BIN_NAME"); | |||
| const BINARY_NAME: &str = env!("CARGO_BIN_NAME"); | |||
There was a problem hiding this comment.
recent rust complains about this
There was a problem hiding this comment.
Removed, if needed can be done elsewhere.
A6GibKm
force-pushed
the
ref-attribute
branch
from
b445eb1
to
2c127af
Compare
A6GibKm
force-pushed
the
ref-attribute
branch
from
2c127af
to
b1f31dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will free us of cloning them.