Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The creation of getGroups.PKNCAdata for use within PKNCA #331

Merged
merged 3 commits into from
Nov 5, 2024
Merged

The creation of getGroups.PKNCAdata for use within PKNCA #331

merged 3 commits into from
Nov 5, 2024

Conversation

DBartlettHP
Copy link
Collaborator

Here is the simple inputting of the suggested function for covering issue #330

@billdenney
Copy link
Owner

Can you please:

  1. Add a test for it
  2. Update the documentation so that it's documented with the other getGroups() functions? (You should be able to mirror one of the others)
  3. Rebuild the documentation with devtools::document()

@billdenney
Copy link
Owner

This looks good to me!

One last thing, can you please add this to the NEWS.md file?

@billdenney
Copy link
Owner

Looks good!

@billdenney billdenney merged commit adbc3af into main Nov 5, 2024
8 checks passed
@billdenney billdenney deleted the getGroups.PKNCAdata_derivation branch November 5, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DBartlettHP @billdenney