-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bwa: update to latest master and add linux-aarch64 #46640
Conversation
84ece6d
to
a685fd8
Compare
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@BiocondaBot please fetch artifacts |
AzureNo artifacts found on the most recent Azure build. Either the build failed, the artifacts have been removed due to age, or the recipe was blacklisted/skipped. CircleCIPackage(s) built on CircleCI are ready for inspection:
You may also use
|
|
@jmarshall What do you think about this approach (using Git SHA) ? |
Such a package would be lying when it claimed to be an accurate rendition of BWA 0.7.17. Me, I would very much rather that @bioconda/core added its voice to advocate for a proper upstream BWA release. I would regret having mentioned those PRs if doing so caused bioconda to do extra work to convert them to local patches. That would be wasted work; the effort would be better put to improving BWA upstream, and later taking advantage of that in our packaging. |
Converted the PR to a Draft until it is decided whether using |
…latest release) Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Fwiw: I added a comment to the upstream issue. |
Superseded by #47224. |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.