Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] owkaplanmeier: change the symbol of censored data #13

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

JakaKokosar
Copy link
Member

Issue

The curve feels crowded when there is a lot of censored samples.

Screenshot 2021-03-10 at 17 08 40

Description of changes

Change the symbol for rendering censored samples (draw lines instead of circles).

Screenshot 2021-03-10 at 17 01 07

Includes
  • Code changes
  • Tests
  • Documentation

@JakaKokosar
Copy link
Member Author

@mstajdohar is this better?

@JakaKokosar JakaKokosar changed the title owkaplanmeier: change the symbol of censored data [ENH] owkaplanmeier: change the symbol of censored data Mar 10, 2021
@mstajdohar
Copy link

Much better, thank you!

@mstajdohar
Copy link

An even better solution would be to display just the upper part of | (just the part above the curve), because you could see the shape of the curve more clearly. I don't know if that's possible, though.

@JakaKokosar
Copy link
Member Author

@mstajdohar I can make it like this
Screenshot 2021-03-11 at 09 42 18

But I'm not sure if it improves the visibilty of the curve if you zoom out.

@mstajdohar
Copy link

Perfect. Can you make the ticks half the size?

@JakaKokosar JakaKokosar force-pushed the kaplan-meier/censor_symbol branch from 0d451d6 to 640d514 Compare March 11, 2021 16:37
@JakaKokosar
Copy link
Member Author

Screenshot 2021-03-11 at 17 37 31

@mstajdohar
Copy link

Fabulous!

@JakaKokosar JakaKokosar merged commit e8a6ce7 into master Mar 12, 2021
@JakaKokosar JakaKokosar deleted the kaplan-meier/censor_symbol branch March 12, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants