Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to IntelliJ Platform Gradle Plugin #77

Merged

Conversation

bc-m
Copy link
Contributor

@bc-m bc-m commented Aug 15, 2024

This merge request migrates this plugin from Gradle IntelliJ Plugin (1.x) to IntelliJ Platform Gradle Plugin (2.x) to add compatibility with IntelliJ IDEs 2024.2+.

https://plugins.jetbrains.com/docs/intellij/api-notable-list-2024.html

Closes #74
Closes #75

@bc-m bc-m force-pushed the feat/migrate-to-intellij-platform-gradle-plugin branch 4 times, most recently from 2929750 to 715574f Compare August 15, 2024 19:05
@bc-m bc-m force-pushed the feat/migrate-to-intellij-platform-gradle-plugin branch from 715574f to 2a8a4eb Compare August 15, 2024 19:48
@bc-m bc-m marked this pull request as ready for review August 15, 2024 20:09
@bc-m
Copy link
Contributor Author

bc-m commented Aug 15, 2024

@ematipico Can you please review this when you have time? Thank you! :)

@ematipico
Copy link
Member

@bc-m Can I release a new version after this PR is merged?

@ematipico ematipico merged commit d3fd606 into biomejs:main Aug 20, 2024
3 checks passed
@bc-m
Copy link
Contributor Author

bc-m commented Aug 20, 2024

@bc-m Can I release a new version after this PR is merged?

"It works on my machine" 😄

I couldn't or didn't know how to test the release steps. These were adjusted in build.gradle.kts. I have made the changes bases on the official plugin-template.

Can you try a nightly release at first?

@ematipico
Copy link
Member

Done! I triggered the workflow

@bc-m
Copy link
Contributor Author

bc-m commented Aug 20, 2024

Done! I triggered the workflow

And... it failed! 😞 I have build it locally and the output file is named intellij-biome-valueof(GradlePropertyValueSource).zip, which seems to be incorrect. I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only old version of plugin is available in latest IDEA version
2 participants