Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: config Dockerfile.benchmark in gitattributes #3516

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

o-az
Copy link
Contributor

@o-az o-az commented Jul 24, 2024

Summary

currently the file doesn't have syntax highlighting in github. Marking it in .gitattributes manually tells github to add Dockerfile syntax highlighting to it

Test Plan

currently the file doesn't have syntax highlighting in github. Marking it in .gitattributes manually tells github to add Dockerfile syntax highlighting to it
Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this PR, but typically I name give files the extension .dockerfile to avoid this problem. I would also accept renaming this file (and updating the name across the codebase).

@o-az
Copy link
Contributor Author

o-az commented Jul 24, 2024

ld also accept renaming this file (and updating the name across the codebase).

I recall somewhere in docker's docs it showing that the convention is Dockerfile.*

@o-az
Copy link
Contributor Author

o-az commented Jul 24, 2024

ld also accept renaming this file (and updating the name across the codebase).

I recall somewhere in docker's docs it showing that the convention is Dockerfile.*

Actually I'm wrong. Looks like it's *.Dockerfile https://docs.docker.com/build/building/packaging/#filename

@ematipico ematipico merged commit b9cfc5f into biomejs:main Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants