feat(lint): add rule noJsxPropsBind

crates/biome_diagnostics_categories/src/categories.rs

@@ -133,6 +133,7 @@ define_categories! {
     "lint/correctness/useValidForDirection": "https://biomejs.dev/linter/rules/use-valid-for-direction",
     "lint/correctness/useYield": "https://biomejs.dev/linter/rules/use-yield",
     "lint/nursery/colorNoInvalidHex": "https://biomejs.dev/linter/rules/color-no-invalid-hex",
+    "lint/nursery/noBind": "https://biomejs.dev/linter/rules/no-bind",
     "lint/nursery/noColorInvalidHex": "https://biomejs.dev/linter/rules/no-color-invalid-hex",
     "lint/nursery/noCommonJs": "https://biomejs.dev/linter/rules/no-common-js",
     "lint/nursery/noConsole": "https://biomejs.dev/linter/rules/no-console",

crates/biome_js_analyze/src/lint/nursery.rs

@@ -2,6 +2,7 @@
 
 use biome_analyze::declare_lint_group;
 
+pub mod no_bind;
 pub mod no_common_js;
 pub mod no_document_cookie;
 pub mod no_document_import_in_page;
@@ -47,6 +48,7 @@ declare_lint_group! {
     pub Nursery {
         name : "nursery" ,
         rules : [
+            self :: no_bind :: NoBind ,
             self :: no_common_js :: NoCommonJs ,
             self :: no_document_cookie :: NoDocumentCookie ,
             self :: no_document_import_in_page :: NoDocumentImportInPage ,

crates/biome_js_analyze/src/lint/nursery/no_bind.rs

@@ -0,0 +1,67 @@
+use biome_analyze::{context::RuleContext, declare_lint_rule, Ast, Rule, RuleDiagnostic};
+use biome_console::markup;
+use biome_js_syntax::JsIdentifierBinding;
+use biome_rowan::AstNode;
+
+declare_lint_rule! {
+    /// Succinct description of the rule.
+    ///
+    /// Put context and details about the rule.
+    /// As a starting point, you can take the description of the corresponding _ESLint_ rule (if any).
+    ///
+    /// Try to stay consistent with the descriptions of implemented rules.
+    ///
+    /// ## Examples
+    ///
+    /// ### Invalid
+    ///
+    /// ```js,expect_diagnostic
+    /// var a = 1;
+    /// a = 2;
+    /// ```
+    ///
+    /// ### Valid
+    ///
+    /// ```js
+    /// // var a = 1;
+    /// ```
+    ///
+    pub NoBind {
+        version: "next",
+        name: "noBind",
+        language: "js",
+        recommended: false,
+    }
+}
+
+impl Rule for NoBind {
+    type Query = Ast<JsIdentifierBinding>;
+    type State = ();
+    type Signals = Option<Self::State>;
+    type Options = ();
+
+    fn run(ctx: &RuleContext<Self>) -> Self::Signals {
+        let _binding = ctx.query();
+        Some(())
+    }
+
+    fn diagnostic(ctx: &RuleContext<Self>, _state: &Self::State) -> Option<RuleDiagnostic> {
+        //
+        // Read our guidelines to write great diagnostics:
+        // https://docs.rs/biome_analyze/latest/biome_analyze/#what-a-rule-should-say-to-the-user
+        //
+        let node = ctx.query();
+        Some(
+            RuleDiagnostic::new(
+                rule_category!(),
+                node.range(),
+                markup! {
+                    "Variable is read here."
+                },
+            )
+            .note(markup! {
+                "This note will give you more information."
+            }),
+        )
+    }
+}

crates/biome_js_analyze/tests/specs/nursery/noBind/invalid.js

@@ -0,0 +1,3 @@
+var a = 1;
+a = 2;
+a = 3;

crates/biome_js_analyze/tests/specs/nursery/noBind/valid.js

@@ -0,0 +1,2 @@
+/* should not generate diagnostics */
+// var a = 1;