WIP-refactoring nesting #57
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itive complexity at ln.96 in utils
…ary-based approach
…Cloud Bot to be above the acceptable threshold for cognitive complexity.
…sk and minor cleaning.
|
Kudos, SonarCloud Quality Gate passed!
|
eagmon
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
looks good @AlexPatrie! sorry for the delayed approval. This looks ready to merge. For the future: change the PR to a non-draft PR when you're ready to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to lower the generalized "cognitive complexity" score assessed by SonarCloud, this pr and branch serves as an effort to lower all cognitive complexity-assessments-points > 1 to be <= 0. Please refer to Issue "Lowering Cognitive complexity as per SonarCloud" for more information.