Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static navigation and include in start.html using th:replace #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ajmorgs
Copy link
Collaborator

@ajmorgs ajmorgs commented Oct 10, 2021

To make the navigation available and consistent across pages, I added the nav as an html page fragment and including it in the start.html page using Thymeleaf th:replace

@ajmorgs
Copy link
Collaborator Author

ajmorgs commented Oct 10, 2021

Added Unit Test according to Test Driven Design

@ajmorgs
Copy link
Collaborator Author

ajmorgs commented Oct 10, 2021

The program has the basic objects we have discussed in the course material.
Project was available in github on time.
Program does not compile.
The project is easy for me to understand.

3 things I learned:

  1. Since my changes were originally done in a separate branch of a different repository than this group had begun, I had to migrate/include my changes into a new branch off the new repository.
  2. I learned about using Thymeleaf th:replace to be able to use a consistent element across multiple html pages
  3. By focusing on designing unit tests first, it is much easier to design the service.

Comment on lines -14 to -21
public ShoppingCart() {
orders = new HashMap<String, CartOrder>();
}

public ShoppingCart(String shoppingId) {
this.shoppingId = shoppingId;
orders = new HashMap<String, CartOrder>();
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

@discospiff
Copy link

Lombok, increased test coverage, and fragments are generally a good idea.
The group should discuss and consider merging, if this meets their needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants